You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* fix: arguments accept units
`max-body-size` and `read-buffer-size` now accept units as defined in the docs.
Fixes#1489
Signed-off-by: Mike Nguyen <hey@mike.ee>
* chore: gofumpt
Signed-off-by: Mike Nguyen <hey@mike.ee>
* refactor: modify logic to comply with vetting
Signed-off-by: Mike Nguyen <hey@mike.ee>
* chore: gofumpt -w .
Signed-off-by: Mike Nguyen <hey@mike.ee>
* refactor: set defaults
`max-body-size` is defaulted to 4Mi
`request-buffer-size` is defaulted to 4Ki
This is inline with the runtime.
Signed-off-by: Mike Nguyen <hey@mike.ee>
* fix: set defaults in run and annotate
Signed-off-by: Mike Nguyen <hey@mike.ee>
* chore: gofumpt
Signed-off-by: Mike Nguyen <hey@mike.ee>
* refactor: exit with error rather than panic
Co-authored-by: Anton Troshin <troll.sic@gmail.com>
Signed-off-by: Mike Nguyen <hey@mike.ee>
---------
Signed-off-by: Mike Nguyen <hey@mike.ee>
Co-authored-by: Anton Troshin <troll.sic@gmail.com>
Expected Behavior
I should be able to define the arguments
max-body-size
andread-buffer-size
with units, e.g. "4Mi" as per docs.https://v1-15.docs.dapr.io/reference/arguments-annotations-overview/
Actual Behavior
At the moment, the flag is being parsed as an int rather than a string before invoking the runtime.
Steps to Reproduce the Problem
Release Note
RELEASE NOTE: FIX Allow
max-body-size
andread-buffer-size
to be defined with unitsThe text was updated successfully, but these errors were encountered: