Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove block types with both execute and availability properties #21

Draft
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

dapplion
Copy link
Owner

Motivation

Those where the good old days..

SignedBeaconBlock --------
         |               |
         |      GossipVerifiedBlock
         |               |
SignatureVerifiedBlock  <-
         |   
ExecutionPendingBlock
         |
        END

Where block types had a linear progression. Now there are two states progressing in parallel: execution + availability. Now block types are nested, featuring a combination of enums and names with double status

  • ExecutionPendingBlock: MaybeAvailableBlock + import data
  • MaybeAvailableBlock:
    • Available: AvailableBlock
    • Not available: SignedBeaconBlock
  • Availability
    • Available: AvailableExecutedBlock
    • Not available: ()
  • ExecutedBlock:
    • Available: AvailableExecutedBlock
    • AvailabilityPending: AvailabilityPendingExecutedBlock
  • AvailabilityPendingExecutedBlock: SignedBeaconBlock + import data
  • AvailableExecutedBlock: AvailableBlock + import data

Changes

This PR explores returning linearity by making availability a property of the block types, since it happens in the background.

SignedBeaconBlock --------
         |               |
         |      GossipVerifiedBlock
         |               |
SignatureVerifiedBlock  <-
         |   
ExecutionPendingBlock
         |
   ExecutedBlock
         |
ExecutedAvailableBlock

TODO

  • Remove AvailabilityPendingExecutedBlock. It's existence does not affect things too much now as its main consumer (the overflow cache) is isolated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant