Remove block types with both execute and availability properties #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Those where the good old days..
Where block types had a linear progression. Now there are two states progressing in parallel: execution + availability. Now block types are nested, featuring a combination of enums and names with double status
ExecutionPendingBlock
:MaybeAvailableBlock
+ import dataMaybeAvailableBlock
:AvailableBlock
SignedBeaconBlock
Availability
AvailableExecutedBlock
()
ExecutedBlock
:AvailableExecutedBlock
AvailabilityPendingExecutedBlock
AvailabilityPendingExecutedBlock
:SignedBeaconBlock
+ import dataAvailableExecutedBlock
:AvailableBlock
+ import dataChanges
This PR explores returning linearity by making availability a property of the block types, since it happens in the background.
TODO
AvailabilityPendingExecutedBlock
. It's existence does not affect things too much now as its main consumer (the overflow cache) is isolated.