Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mocha related dependencies #23

Closed
wants to merge 3 commits into from

Conversation

nazarhussain
Copy link
Collaborator

@nazarhussain nazarhussain commented Nov 18, 2024

Motivation

Use latest dependencies.

Description

  • Update Typescript
  • Update Mocha
  • Update Chai
  • Update Yargs

Steps to test or reproduce

  • Run all tests

"@typescript-eslint/eslint-plugin": "^4.28.0",
"@typescript-eslint/parser": "^4.28.0",
"chai": "^4.3.4",
"chai": "^4.5.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not latest version, but last version supporting commonjs.

@dapplion
Copy link
Owner

Thanks! There's CI failures

@dapplion
Copy link
Owner

More failures

@nazarhussain
Copy link
Collaborator Author

@dapplion Seems like the error related tot he permission for the repo.

HttpError: Resource not accessible by integration

As locally it's passing fine.

❯ yarn benchmark --local ./cache
yarn run v1.22.22
$ node -r ts-node/register src/cli.ts 'test/perf/**/*.test.ts' --local ./cache
(node:82834) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
Connected to historyProvider: LocalHistoryProvider, dirpath ./cache
No previous bencharmk found for latestCommitInBranch 'main'


  Array iteration
    ✔ Regular test
    ✔ sum array with raw for loop                                         849.7938 ops/s    1.176756 ms/op        -       8683 runs   10.7 s
    ✔ sum array with reduce                                               170.7566 ops/s    5.856289 ms/op        -        127 runs   1.25 s
    ✔ sum array with reduce beforeEach                                    171.8360 ops/s    5.819502 ms/op        -        171 runs   1.56 s
    ✔ sum array with reduce before beforeEach                             175.4948 ops/s    5.698174 ms/op        -        220 runs   1.76 s
    - sum array with reduce
    ✔ sum array with reduce high threshold                                175.2783 ops/s    5.705213 ms/op        -        548 runs   3.63 s
    ✔ sum array with reduce no threshold                                  180.2968 ops/s    5.546410 ms/op        -        152 runs   1.35 s


  7 passing (20s)
  1 pending

✨  Done in 21.71s.

@dapplion
Copy link
Owner

Would like to have green CI, do you have capacity to look into the permissions issue? I can make you mantainer too

@nazarhussain
Copy link
Collaborator Author

Would like to have green CI, do you have capacity to look into the permissions issue? I can make you mantainer too

Sure that will be helpful to debug.

@nazarhussain
Copy link
Collaborator Author

Closing in favor of #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants