Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hevm: fix prove tests for latest ds-test #948

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

d-xo
Copy link
Contributor

@d-xo d-xo commented Jun 29, 2022

Since dapphub/ds-test#30 calls to failed() can
contain reverting branches due to the call into abi.decode().

This meant that using prove tests with the latest ds-test version would
always fail with a hard error.

This change updates the symbolic test stepper to correctly report
bailed as true for branches that reverted during the call to
failed().

Description

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

Since dapphub/ds-test#30 calls to `failed()` can
contain reverting branches due to the call into abi.decode().

This meant that using prove tests with the latest ds-test version would
always fail with a hard error.

This change updates the symbolic test stepper to correctly report
`bailed` as true for branches that reverted during the call to
`failed()`.
@d-xo d-xo merged commit cb2e4ca into master Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant