Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NBA-2977: Added back from FulfillFromIssuer method for NBA TS. #72

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

judezhu
Copy link
Collaborator

@judezhu judezhu commented Aug 26, 2024

the FulfillFromIssuer method was in the deployed version in the testnet/mainnet before, but the method is not checked in the codebase.

@judezhu judezhu requested a review from a team as a code owner August 26, 2024 06:57
@judezhu judezhu changed the title Added back from FulfillFromIssuer method for NBA TS. Added back from FulfillFromIssuer method for NBA TS. Aug 26, 2024
Copy link
Contributor

@loic1 loic1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@judezhu judezhu merged commit c6fc23c into stable-cadence Aug 26, 2024
1 check passed
@judezhu judezhu deleted the judez/add-fullfill-from-issuer branch August 26, 2024 17:10
@judezhu judezhu changed the title Added back from FulfillFromIssuer method for NBA TS. NBA-2977: Added back from FulfillFromIssuer method for NBA TS. Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants