Inbox unread filter fixes

[elatif2020]

• For some reason, when I don't have any unread streams it show an empty inbox (with only unread messages view), but when I have one or some unread messages, it shows me them plus two more streams -- the Autumn DEV one and a DM with Daniel (which, btw, doesn't appear in my inbox in the regular view).

• Include also New streams (streams with the New badge) that have recently been created but which don't have yet any message on them.

[danielr18]

Fixed a related issue.

The FE is caching the inbox items some way which leads to unknown behavior on what inbox items are displayed.

[danielr18]

Example of the inbox showing all items when unread inbox items are only 2

[andreymikhadyuk]

Regarding real-time unread messages update: waiting for the further updates from @elatif2020.

[elatif2020]

There are some issues we should fix here, but first we should hide this option to deploy to production
#2336

The fixes we need (afterward):

• change to include also "new" items and items marked as unread
• add a solution for real time updates (we should converge here first on what solution to take), see the common discussion here: https://common.io/commons/7e9bc381-6365-4b6d-8379-d2c1fe8a7f8f?item=d94bab2c-8f5c-4883-bc32-90cf6f01b613

[andreymikhadyuk]

@elatif2020 I do not fully understand what should be done from the FE side here regarding you first point. I think it is related to BE endpoint. @danielr18 Correct me please if I am wrong.

[andreymikhadyuk]

@danielr18 I think that I can add background loading of the unread items in the following way:

1. check inbox counter and if it changes then do next steps
2. call the inbox endpoint with unread flag again until the first item which is displayed to user at the moment
3. add new items to the list

That's the plan. Am I correct that I do not need to worry about the items between currently displayed items and after them? I think that any new unread will have last activity later than the first item which is displayed right now.

[NoamQA]

@elatif2020
we dont have unread button in the inbox right?
checked with this link: https://web-dev.common.io/inbox?unread=true
works fine for me
can you check in your inbox that the 2 channels doesnt appear?

[elatif2020]

@elatif2020 we dont have unread button in the inbox right? checked with this link: https://web-dev.common.io/inbox?unread=true works fine for me can you check in your inbox that the 2 channels doesnt appear?

@NoamQA
ok yes it also better for me
but I'm not sure whether it's fully fixed, might worth additional checking

[NoamQA]

ok tested on several users
it looks good in all of them

[elatif2020]

@danielr18 @andreymikhadyuk
See in the screenshot. It's on DEV, same after refresh.

• I marked the item "light" as read but it stays with the unread=true filter (it disappeared only after marking another item as unread)

• Inbox counter doesn't match the number of items.

[NoamQA]

@elatif2020 @danielr18
now when i use link https://web-dev.common.io/inbox?unread=true
in vev or in web stage
i get more items than appear in the counter
it wasnt like this until now
and in prod i do get the same items
is it OK for us?

[NoamQA]

@elatif2020 @danielr18
i still have more items than counter
especially in web stage

[elatif2020]

@elatif2020 @danielr18 i still have more items than counter especially in web stage

@NoamQA
We need to test this on dev. This option isn't enabled on staging.
Also can you please check whether it stays after refresh, and whether it reproduce in a private tab?

[NoamQA]

@elatif2020
yes it stays after refresh and cache clean
and also in private tab

[elatif2020]

Okay, thanks
In this case I guess the issue is in the BE
@andreymikhadyuk can you verify?

[andreymikhadyuk]

@NoamQA Please provide your user's email.

[andreymikhadyuk]

@elatif2020 @NoamQA If Noam's email is harmony777777@gmail.com, then the image below is correct for this case. You can see that inbox counter is 0, but there are 12 items with unread = true:

[elatif2020]

Thanks @andreymikhadyuk 🙏
So as I understand we need a fix here in the BE

[elatif2020]

@danielr18