Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix daoCreator #381

Merged
merged 1 commit into from
Dec 1, 2018
Merged

fix daoCreator #381

merged 1 commit into from
Dec 1, 2018

Conversation

dkent600
Copy link
Contributor

@dkent600 dkent600 commented Nov 30, 2018 •
edited
Loading

  • fix problem with Dao.new where DAOs created by scripts executed in the context of clients were not recognizing schemes as being universal, resulting in schemes with no parameters
  • fix issues with TokenCapGC API
  • remove inappropriate and redundant methods in ContractWrapperBase

Breaking
TokenWrapperGC.getSchemeParametersHash =>TokenWrapperGC. getRegisteredParametersHash
TokenWrapperGC.getSchemeParameters =>TokenWrapperGC. getRegisteredParameters

@dkent600 dkent600 self-assigned this Nov 30, 2018
@dkent600 dkent600 merged commit fc98124 into master Dec 1, 2018
@dkent600 dkent600 deleted the fixDaoCreator branch December 3, 2018 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tibetsprague tibetsprague tibetsprague approved these changes

@jellegerbrandy jellegerbrandy Awaiting requested review from jellegerbrandy

Assignees

@dkent600 dkent600

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkent600 @tibetsprague