Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stub out/correct broken GP parameters #377

Merged
merged 10 commits into from
Nov 27, 2018
Merged

Stub out/correct broken GP parameters #377

merged 10 commits into from
Nov 27, 2018

Conversation

dkent600
Copy link
Contributor

@dkent600 dkent600 commented Nov 26, 2018 •
edited
Loading

Resolves: #338

  • stubs out broken GP parameters: daoBountyConst, daoBountyLimit and voteOnBehalf
  • repairs the other parameters
  • refactors ContractWrapper class hierarchy

@orenyodfat
Copy link
Contributor

I guess that this pr include other things except of the gp params .right ? it has 19 files changed

@dkent600
Copy link
Contributor Author

dkent600 commented Nov 26, 2018 •
edited
Loading

@orenyodfat Yes, I am feeling quite sheepish about that.

I just added the description that describes the changes. I originally thought these other changes were relevant. Turns out they aren't, though they are desirable. Though they are low risk, they aren't necessary. I have a question posed to @jellegerbrandy as to whether he wants to take them.

@dkent600
Copy link
Contributor Author

@orenyodfat @jellegerbrandy

Here is a PR that does not include the refactoring, in case you don't want to take the refactoring:

daostack/arc.js#378

@dkent600 dkent600 self-assigned this Nov 26, 2018
@dkent600 dkent600 mentioned this pull request Nov 26, 2018
Closed
@dkent600 dkent600 changed the title Stub out broken GP parameters Stub out and correct broken GP parameters Nov 26, 2018
@dkent600 dkent600 changed the title Stub out and correct broken GP parameters Stub out/correct broken GP parameters Nov 26, 2018
jellegerbrandy
jellegerbrandy approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@jellegerbrandy jellegerbrandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good to me. Hard for me to judge the refactoring part.

@dkent600 dkent600 merged commit 1fce079 into master Nov 27, 2018
@dkent600 dkent600 deleted the fixGPParamsFunctions branch November 27, 2018 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jellegerbrandy jellegerbrandy jellegerbrandy approved these changes

@orenyodfat orenyodfat Awaiting requested review from orenyodfat

Assignees

@dkent600 dkent600

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkent600 @orenyodfat @jellegerbrandy