Skip to content

Commit

Permalink
Wait for slow tags in golden tests
Browse files Browse the repository at this point in the history
  • Loading branch information
daohoangson committed Nov 17, 2023
1 parent 52f5e68 commit e6a6275
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
3 changes: 3 additions & 0 deletions demo_app/test/golden_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ void _test(
textScaleSize: textScaleSize,
);

// wait for slow tags like AUDIO, VIDEO, etc.
await tester.pumpAndSettle();

await screenMatchesGolden(tester, name, finder: find.byKey(key));
debugDefaultTargetPlatformOverride = null;
WidgetFactory.debugDeterministicLoadingWidget = false;
Expand Down
8 changes: 1 addition & 7 deletions packages/fwfh_chewie/test/mock_video_player_platform.dart
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,7 @@ class _FakeVideoPlayerPlatform extends Fake

@override
Widget buildView(int textureId) {
return const DecoratedBox(
decoration: BoxDecoration(
border: Border.fromBorderSide(
BorderSide(color: Colors.grey),
),
),
);
return const Placeholder();
}

@override
Expand Down

1 comment on commit e6a6275

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.