feat: add support for currency #10
Conversation
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 86.76% 87.00% +0.23%
==========================================
Files 8 8
Lines 544 554 +10
Branches 68 71 +3
==========================================
+ Hits 472 482 +10
Misses 71 71
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Implementation of [Chapter 10] of _Crafting Interpreters_. I wondered back in #10 whether I'd be shooting myself in the foot by supporting `,` as a number separator (`1,234`). This is where it happened. The comma becomes quite ambiguous in the arguments list of a function call. For exmaple: ``` f(1,234,567); ``` Is that a call to `f` with a single argument, `1,234,567` or a call to `f` with three arguments, `1`, `234` and `567`? The grammar is ambiguous. My solution is to make spaces significant while scanning: ``` f(1,234,567); // one argument f(1, 234, 567); // three arguments ``` We'll see how this holds up! [Chapter 10]: https://craftinginterpreters.com/functions.html
This is off track from the book, but I thought it would be a fun extension to support expressions like
$12.34 + $13.78.Any mix of units is allowed for now, though I might want to tweak this in the future. For example
2 * $12.34makes sense but2 + $12.34probably doesn't.