Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssl flags #174

Merged
merged 9 commits into from
Jun 16, 2023
Merged

Add ssl flags #174

merged 9 commits into from
Jun 16, 2023

Conversation

danvergara
Copy link
Owner

@danvergara danvergara commented Jun 2, 2023

Add SSL connection flags/query params

Description

When it comes to SSL connection, dblab assumes that you have the default files set in your system (e.g., ~/.postgresql/root.crt) and there's no way to customize this behavior right now.

Fixes #153

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Ran the new feature in my system, QA'ing the app by trying multiple scenarios

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@danvergara danvergara self-assigned this Jun 2, 2023
@danvergara danvergara marked this pull request as ready for review June 13, 2023 04:30
@danvergara danvergara requested a review from valerybriz June 13, 2023 04:30
Copy link
Collaborator

@valerybriz valerybriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 I will add an issue to add this feature to the documentation

@danvergara danvergara merged commit a28c8df into main Jun 16, 2023
@danvergara danvergara deleted the add-ssl-flags branch July 25, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSL connection related flags for Postgres
2 participants