-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mysql socket conn #149
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danvergara
added
kind/enhancement
New feature or request
intermediate
Good for intermediate developers
labels
Mar 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Makefile
Outdated
@@ -13,7 +13,7 @@ unit-test: | |||
.PHONY: int-test | |||
## int-test: Runs the integration tests | |||
int-test: | |||
docker-compose run --entrypoint=make dblab test | |||
docker compose run --entrypoint=make dblab test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I´d like to have this change in other PR rather than put it here on this feature branch.
danvergara
force-pushed
the
add-mysql-socket-conn
branch
from
March 15, 2023 02:19
b88bdf1
to
e1393a8
Compare
…file exists or is valid
build(make): replace docker-compose with compose v2
…ing the url option
… file fix(make): delete docker compose v2
danvergara
force-pushed
the
add-mysql-socket-conn
branch
from
March 15, 2023 02:58
e1393a8
to
2ca392c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new way to connect to MySQL through
Unix Sockets
. Therefore the--socket
flag was added.Fixes #125
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Followed this guide to install MySQL/MariaDB on my local system.
Inspected the
/etc/my.cnf.d/community-mysql-server.cnf
config file to see where the socket file was.Then, I managed to connect to MySQL through that socket file as expected.
Checklist: