Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing special characters #18

Closed
wants to merge 2 commits into from
Closed

Conversation

ericel
Copy link

@ericel ericel commented Jan 24, 2017

The present state of the slugify function does escape or remove special characters.
For instance , it can't slugify a url {{"https://github.com/danrevah" | slugify}} and will cause problems in angular2 routes.
So add the regex to remove special characters output : https-github.com-danrevah

The present state of the slugify function does escape or remove special characters.
For instance , it can't slugify a url {{"https://github.com/danrevah" | slugify}} and will cause problems in angular2 routes.
So add the regex to remove special characters output : https-github.com-danrevah
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling aa82a46 on ericel:patch-1 into 509cb47 on danrevah:master.

@danrevah
Copy link
Owner

danrevah commented Jan 24, 2017

Nice catch. but the space in the regex was redundant (I've changed it).
Do you wanna add a test case for it so I will merge it?

@coveralls
Copy link

coveralls commented Jan 24, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 2390012 on ericel:patch-1 into 509cb47 on danrevah:master.

@ericel
Copy link
Author

ericel commented Jan 25, 2017

That's okay! I love your module and am happy to see it working fine.

danrevah added a commit that referenced this pull request Jan 26, 2017
@danrevah
Copy link
Owner

Fixed and published to @1.2.3

Commit: 376cff7

@danrevah danrevah closed this Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants