Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strictNullChecks errors #29

Closed
softsimon opened this issue Feb 20, 2017 · 1 comment
Closed

strictNullChecks errors #29

softsimon opened this issue Feb 20, 2017 · 1 comment
Labels
bug

Comments

@softsimon
Copy link
Contributor

Getting a few errors from this lib when enabling strictNullChecks in tsconfig.json in my project.

ERROR in [..]/node_modules/ngx-pipes/src/app/pipes/object/invert-by.ts (7,23): Type 'null' is not assignable to type 'Function'.)

ERROR in [..]/node_modules/ngx-pipes/src/app/pipes/helpers/helpers.ts (39,6): An index expression argument must be of type 'string', 'number', 'symbol', or 'any'.)
softsimon added a commit to softsimon/ngx-pipes that referenced this issue Feb 20, 2017
@softsimon
Avoid errors when running in strictNullChecks mode. (danrevah#29)
96f23ab
danrevah pushed a commit that referenced this issue Feb 20, 2017
@softsimon @danrevah
Avoid errors when running in strictNullChecks mode. (#29) (#30)
fefec51
@danrevah
Copy link
Owner

Thanks @softsimon !

I've merged your changes and it's now published to npm from version v1.4.4.

@danrevah danrevah added the bug label Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danrevah @softsimon