Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular Seed & ngx-pipes #23

Closed
Meistercoach83 opened this issue Feb 6, 2017 · 5 comments
Closed

Angular Seed & ngx-pipes #23

Meistercoach83 opened this issue Feb 6, 2017 · 5 comments
Labels

Comments

@Meistercoach83
Copy link

Meistercoach83 commented Feb 6, 2017

Hey there!
I tried to integrate your pipes-module in the angular-seed from mgechev (https://github.com/mgechev/angular-seed/), but got some problems. I opened an issue for it: mgechev/angular-seed#1794.

The last answer was helpful for me - now I can use it in dev. But could you do add this to your project: "The production build won't work out of the box because the author of the library hasn't disabled implicit any. Also, the package is not distributed with metadata.json files which means that AoT won't work neither"

danrevah added a commit that referenced this issue Feb 6, 2017
danrevah added a commit that referenced this issue Feb 6, 2017
danrevah added a commit that referenced this issue Feb 6, 2017
@danrevah
Copy link
Owner

danrevah commented Feb 6, 2017

Hey @Meistercoach83,

Regarding the disabling of the implicit any, I've published a fixed version to v1.3.3.
Let me know if this fixes your problem.

I'm not entirely sure what needs to be done in order to make this library compliant with AoT.
I will find a time to dig into that to figure it out.

@Meistercoach83
Copy link
Author

Hey! Thanks for your fast response. The updated package is ok. No errors are thrown any longer. I´ll give it a try.

@danrevah
Copy link
Owner

danrevah commented Feb 6, 2017

Cool. keep me updated if anything changes.
I'm keeping this issue open until i'll have time figure the AoT.

You are also welcome to send a pull-request if you already know what's missing.

@danrevah
Copy link
Owner

danrevah commented Feb 7, 2017

@Meistercoach83
AoT with tree shaking is now working from v1.4.0 :)
Tested with angular-cli & webpack.

@danrevah
Copy link
Owner

danrevah commented Feb 8, 2017

I'm closing it for now let me know if this needs to be reopened.

@danrevah danrevah closed this as completed Feb 8, 2017
@danrevah danrevah added the bug label Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants