Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom delimiter support in 'groupBy' pipe while grouping multiple fields #22

Closed
shikhartanwar opened this issue Feb 1, 2017 · 5 comments
Assignees
Labels

Comments

@shikhartanwar
Copy link

shikhartanwar commented Feb 1, 2017

Custom delimiter as an additional optional argument in the groupBy pipe would be really helpful. Currently multiple fields are joined by _ while grouping on multiple fields but _ would not always be a unique delimiter and in that case the resultant map cannot be directly used.

@danrevah
Copy link
Owner

danrevah commented Feb 1, 2017

Did you mean that multiple fields are joined by underscore ("_")? and yes this makes sense if there's some properties with _ it won't always be unique.
I will add a custom delimiter as suggested.

@shikhartanwar
Copy link
Author

Yes. I was referring to multiple fields getting joined by "_" only.

@danrevah
Copy link
Owner

danrevah commented Feb 1, 2017

I think that it might be better to also use : as default.
since "_" is commonly used as property name.
I will make the required adjustments.

@shikhartanwar
Copy link
Author

shikhartanwar commented Feb 1, 2017

Yes. That makes perfect sense. : or maybe | would be better options as the default delimiter.

@danrevah
Copy link
Owner

danrevah commented Feb 1, 2017

Default has been changed to |.
I've also added an option to change the delimiter.

https://github.com/danrevah/ngx-pipes#groupby
Release version: v1.3.2

@danrevah danrevah closed this as completed Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants