Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally list checkers in html report #7031

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Conversation

martyone
Copy link
Contributor

No description provided.

@firewave
Copy link
Collaborator

Thanks for your contribution.

It would be nice if you could add a basic test for this.

@danmar
Copy link
Owner

danmar commented Dec 6, 2024

yeah.. I also like the idea to have a test. There are no existing tests are there? I don't see any.
A test that execute cppcheck with --checkers-report and then check if htmlreport handles the output in some good way sounds good..

@firewave
Copy link
Collaborator

firewave commented Dec 6, 2024

We have the tests for htmlreport. Just adding some executions with the new option and checking that the syntax is correct should be enough as a start.

@danmar
Copy link
Owner

danmar commented Dec 8, 2024

Just adding some executions with the new option and checking that the syntax is correct should be enough as a start.

ok so I grepped.. and I assume the tests you talk about are located here:

test/tools/htmlreport/test_htmlreport.py

So @martyone please add a test..

@martyone
Copy link
Contributor Author

Added a test case.

@danmar danmar merged commit e3dceac into danmar:main Jan 1, 2025
@danmar
Copy link
Owner

danmar commented Jan 1, 2025

I merged your changes. As far as I see you have not contributed to cppcheck before and therefore I would like to add you to our AUTHORS file. What name would you like that I add in AUTHORS?

@martyone
Copy link
Contributor Author

martyone commented Jan 6, 2025

Thank you. Yes, it's my first contribution. I think credit should go to the company, so can we add the company name instead of my name? It is "Seafarix Ltd."

@danmar
Copy link
Owner

danmar commented Jan 9, 2025

@martyone alright. I have added it: 01005d2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants