refs #12021 - CI-windows.yml: fail build on compiler warnings / some cleanups #6982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2794213 to
41600d0
Compare
0a6bcd5 to
1b0909f
Compare
| @@ -288,9 +288,9 @@ void ResultsTree::setReportType(ReportType reportType) { | |||
| if (!fileItem) | |||
| continue; | |||
| for (int j = 0; j < fileItem->rowCount(); ++j) { | |||
| const auto& data = fileItem->child(j,0)->data().toMap(); | |||
There was a problem hiding this comment.
Was there variable shadowing related to data? If so, could we detect that?
There was a problem hiding this comment.
D:\a\cppcheck\cppcheck\gui\resultstree.cpp(291,32): warning C4458: declaration of 'data' hides class member [D:\a\cppcheck\cppcheck\build\gui\cppcheck-gui.vcxproj]
D:\a\cppcheck\Qt\5.15.2\msvc2019_64\include\QtWidgets/qwidget.h(747,18): message : see declaration of 'QWidget::data' (compiling source file D:\a\cppcheck\cppcheck\gui\resultstree.cpp) [D:\a\cppcheck\cppcheck\build\gui\cppcheck-gui.vcxproj]
Not something we can detect until the system header is included. Also I think that compilers have this covered.
I just had a look at enabling -Wshadow-field for Clang but that warning has a wider scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.