Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added remaining make targets to CMake #4026

Closed
wants to merge 3 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
renamed CMake target check to check-ctest
  • Loading branch information
firewave committed Dec 2, 2023
commit 9c7fcc0c33aa7f200508f1f559ce713d2d120602
2 changes: 1 addition & 1 deletion test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ if (BUILD_TESTS)
ProcessorCount(N)
set(CTEST_PARALLEL_LEVEL ${N} CACHE STRING "CTest parallel level")
set(CTEST_TIMEOUT 90 CACHE STRING "CTest timeout")
add_custom_target(check ${CMAKE_CTEST_COMMAND} --output-on-failure -j ${CTEST_PARALLEL_LEVEL} -C ${CMAKE_CFG_INTDIR} --timeout ${CTEST_TIMEOUT}
add_custom_target(check-ctest ${CMAKE_CTEST_COMMAND} --output-on-failure -j ${CTEST_PARALLEL_LEVEL} -C ${CMAKE_CFG_INTDIR} --timeout ${CTEST_TIMEOUT}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to have check run ctest as currently does. I dont see the purpose of renaming this target.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to align it with the Makefile for now. This target (among others) will be deprecated since it is totally unnecessary since you should just use the ctest command.

Copy link
Contributor

@pfultz2 pfultz2 Apr 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most developers(including me) use make check to run the tests with ctest. I really dont want to see it change to something that is suboptimal.

Also, its shorter to do make -j $(nproc) check than doing make -j $(nproc) cppcheck testrunner && ctest --output-on-failure -j $(nproc) ., so this shouldn't be removed either.

DEPENDS testrunner cppcheck)

set(SKIP_TESTS "" CACHE STRING "A list of tests to skip")
Expand Down