Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI-windows.yml: added windows-2022, removed QT 5.9.9 and use msbuild instead of CMake for now #3730

Merged
merged 4 commits into from
Feb 4, 2022

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Jan 20, 2022

No more need for Qt 5.9.9 since it is now covered by the ubuntu-18.04 build. Also we need to update Windows to Qt 6.2 and drop 5.15.2 as well since 6.x versions are the only version we can get updates for as a non-paying "customer".

@firewave firewave force-pushed the win2022 branch 3 times, most recently from a110f38 to b32aa16 Compare February 4, 2022 11:10
@firewave firewave changed the title Win2022 CI-windows.yml: added windows-2022, removed QT 5.9.9 and use msbuild instead of CMake for now Feb 4, 2022
@firewave
Copy link
Collaborator Author

firewave commented Feb 4, 2022

I will add back CMake as additional build step later. As Qt 6.2.x will be added soon and I will not be adjusting qmake for it we need CMake anyways. msbuild and qmake will also surely go away.

But first I will align this with release-windows.yml and share steps between them via https://docs.github.com/en/actions/using-workflows/reusing-workflows.

Regarding Qt 5.9.9 EOL - see https://endoflife.date/qt.

@firewave firewave marked this pull request as ready for review February 4, 2022 13:31
@danmar
Copy link
Owner

danmar commented Feb 4, 2022

Also we need to update Windows to Qt 6.2 and drop 5.15.2 as well since 6.x versions are the only version we can get updates for as a non-paying "customer".

I see no problem to drop support for oldish Qt.

I believe we can require recent compilers/libs to build the GUI.

@danmar danmar merged commit c2b5cdc into danmar:main Feb 4, 2022
@firewave firewave deleted the win2022 branch February 4, 2022 18:44
@firewave
Copy link
Collaborator Author

firewave commented Feb 4, 2022

I believe we can require recent compilers/libs to build the GUI.

The problem with Qt is that you have to pay for 5.15.x updates so 6.2.x is the only supported version freely available on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants