CI-unixish.yml: Use Qt version provided by the distro #3729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h fix into separate one
…one / also enabled Qt installation and GUI build on MacOS
QCOMPARE is stricter about the types in older Qt versions
"qcollectiongenerator" as deprecated in favor of "qhelpgenerator"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a fixed Qt version is convenient in the CI but this is not possible for users of the distro we are testing on. We should use the provided one to make sure we can actually build on that platform (in case of ubuntu-18.04 it did not...well, technically it failed linking).
The install of Qt is also faster than
jurplel/install-qt-action@v2(installing all software on ubuntu takes about 45s whereas Qt alone took 1m15s before) and will obviously be more stable as well.The remaining jobs which cannot do this will be updated to cache the Qt installation soon.