Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert exprengine changes to fix CI on appveyor #3668

Closed
wants to merge 2 commits into from

Conversation

pfultz2
Copy link
Contributor

@pfultz2 pfultz2 commented Jan 3, 2022

No description provided.

@firewave
Copy link
Collaborator

firewave commented Jan 3, 2022

I think it's just incomplete support for constexpr.

Since it was said that removing support for older Visual Studio versions is fine (see #3596 (comment)) we could probably keep this code and just disconnect Appveyor from this repository (but keep the configuration files until everything is moved to GitHub actions) since older GCC versions are fine.

@pfultz2
Copy link
Contributor Author

pfultz2 commented Jan 3, 2022

Alright, here is a PR that removes appveyor:

#3669

@danmar
Copy link
Owner

danmar commented Jan 3, 2022

sorry for this trouble I try to fix it ASAP

@firewave
Copy link
Collaborator

firewave commented Jan 4, 2022

Since this now builds we can close this.

@danmar danmar closed this Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants