Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed line seems to not be necessary. I have been testing removing it and everything went good, even modifying the
bool logging
totrue
inhunalign/src/hunalign/translate.cpp
Line 181 in 2fbcbc9
Until now, Bitextor have been using Hunalign for years from an own repository which contained the Hunalign release 1.2, but now that there is an official repo, we would like to use it directly instead. The problem is that the generated file
translated.txt
is always generated, even whenlogging = false
, which is the default value. This file is not necessary when the logging is disabled, and it is not necessary since when the file is opened becauselogging = true
, it is generated if does not exist (std::ios::app
creates the file if does not exist). Doing this, we avoid to generate this file if it is not necessary, since if any other file with the same name exists, it will rewrite its content as I have tested that happens (the reason is that the default opening mode forofstream
isstd::ios::out
).