Add topic and group exclusion parameters #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 20, 2023 14:35
danielqsj
requested changes
May 22, 2023
README.md
Outdated
| @@ -117,7 +117,9 @@ This image is configurable using different flags | |||
| | server.tls.cert-file | | The certificate file for the web server | | |||
| | server.tls.key-file | | The key file for the web server | | |||
| | topic.filter | .* | Regex that determines which topics to collect | | |||
| | topic.exclude | .* | Regex that determines which topics to exclude | | |||
There was a problem hiding this comment.
Good catch, fixed!
|
@bluesliverx thanks, pls fix the typo |
|
LGTM |
This was referenced May 23, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #91 #103 #104 #127 #170 #217 and #93 (but solves it a different way that allows for both inclusion and exclusion). These PRs all seem to be out of date and have conflicts, so I took the main implementation from both and included them in this new PR. I'm happy to close and improve old PRs, but it would just be more work at this point.
Hopefully this can finally get some traction and get in since our kafka exporter pods are having a lot of trouble with some canary/health check consumer groups that don't need to be reported.