Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing bus logging cannot natively be skipped for stack and merge functions #1127

Closed
ErikSchulze1796 opened this issue Jan 14, 2025 · 0 comments

Comments

@ErikSchulze1796
Copy link

ErikSchulze1796 commented Jan 14, 2025

Python version

('python=3.11.9 (tags/v3.11.9:de54cf5, Apr 2 2024, 10:12:12) [MSC v.1938 64 '
'bit (AMD64)]')
'os=Windows-10-10.0.19045-SP0'
'numpy=1.26.4'
ldf is not supported
xls is not supported
xlsx is not supported
yaml is not supported
'asammdf=8.0.1'

MDF version

4.10

Description

The issue I am facing is not an error but more a missing condition for the MDF.stack() and MDF.merge methods. In

merged._process_bus_logging()

and
stacked._process_bus_logging()

there is no condition that makes it possible to skip the processing of the bus logging as in
if self._kwargs.get("process_bus_logging", True):

If there is f.ex. a dbc file as an attachment path embedded in the mf4 file but I do not want to use that attachment defined there, I possibly get warnings and the CAN frames might get misinterpreted. If I could just add the kwarg process_bus_logging=false, it would be way more simple. Now I have to actively set the attachment path to "" in order for the frames to not get misinterpreted.

Also, there is no documentation on the kwarg process_bus_logging at all. I had to really dig into the code to even find out that this processing messed up my resulting mf4 file.

Maybe this is intentional, but I do not see any reason why a user should not be able to deactivate the processing, if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant