Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes danielgtaylor/aglio#62 #66

Merged

Conversation

bartocc
Copy link
Contributor

@bartocc bartocc commented Oct 14, 2014

Do not condition the rendering of request and response description on headers presence, but on the actual description presence.

Should we also use the request.description in the hash() used for the id generation ?

Do not condition the rendering of request and response description on headers presence, but on the actual description presence
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling adb0a01 on bartocc:62-rendering-response-description into bb0baeb on danielgtaylor:master.

@danielgtaylor
Copy link
Owner

This looks great, thanks for the fix! 👍

danielgtaylor added a commit that referenced this pull request Oct 19, 2014
Do not require headers to render req/res description. Fixes #62, #66.
@danielgtaylor danielgtaylor merged commit 4ebbd4b into danielgtaylor:master Oct 19, 2014
@bartocc bartocc deleted the 62-rendering-response-description branch October 20, 2014 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants