Replace TwiML macros with Macro.postwalk/2
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It’s better to let the user of the library figure out how to keep track of which options were presented to the user than provide this API. It just complicates the implementation at this point. Therefore, removed!
It isn’t necessary to generate a macro for each Twilio verb. The library can have less code (and clearer code!) by using `Macro.postwalk/2` to expand all the verbs in the AST into `tag` and `text` calls. This gives the illusion that there is a macro for each TwiML verb, but without having to actually define one. Plus, the transformation from verb to the `tag` macro is better defined and commented now.
fcc35ff to
49c0997
Compare
danielberkompas
added a commit
that referenced
this pull request
Sep 12, 2015
Replace TwiML macros with `Macro.postwalk/2`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It isn’t necessary to generate a macro for each Twilio verb. The library
can have less code (and clearer code!) by using
Macro.postwalk/2to expand all the verbs in the AST intotagandtextcalls.This gives the illusion that there is a macro for each TwiML verb, but
without having to actually define one. Plus, the transformation from verb
to the
tagmacro is better defined and commented now.This PR also removes the
optionmacro, since I doubt anyone is using it, andit unecessarily complicates things.