Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header: Support custom logos #1281

Merged
merged 9 commits into from
Feb 2, 2025
+131 −8
Merged

Header: Support custom logos #1281

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6eb6963
feat: add logo prop to the Header component to allow for custom logo …
Jan 23, 2025
42b8068
fix: update code style to use the _logo variable name, and update the…
Jan 27, 2025
8fa1a4f
fix: improve the logo props to allow for null to be passed in to repr…
Jan 27, 2025
f2ca068
fix: show the custom logo even for GovUK branded pages
Jan 27, 2025
d4f9b04
feat: update storybook for Header component to reflect new options
Jan 27, 2025
0b0d030
Update components/header/src/Header.tsx
wildtangent Jan 31, 2025
6083e7a
Update components/header/src/Header.tsx
wildtangent Jan 31, 2025
1011b5a
Update components/header/src/Header.tsx
wildtangent Jan 31, 2025
7e1e255
Update components/header/src/Header.tsx
wildtangent Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
Update components/header/src/Header.tsx 
Co-authored-by: Daniel A.C. Martin <daniel-ac-martin@users.noreply.github.com>
@wildtangent @daniel-ac-martin
wildtangent and daniel-ac-martin authored Jan 31, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 7e1e2555d96cc14e6a61b1af95dc29d5094e09ad
2 changes: 1 addition & 1 deletion components/header/src/Header.tsx
View file
Original file line number Diff line number Diff line change
@@ -125,7 +125,7 @@ export const Header: FC<HeaderProps> = ({
<A href={orgHref} classModifiers={[ 'homepage', (orgText && orgText.length > 9) ? 'small' : undefined ]}>
{
govUK
? headerLogo
? logo
: (
<Fragment>
{logo}