DateInput: Fix type of value props #1260
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DateInput
component types for thevalue
anddefaultValue
prop expect to be both the default type for theInputHTMLAttributes<HTMLInputElement>,
e.g.string | string[] | undefined
but ALSO aDateInputValue
which expects an object of.{ day: string, month: string, year: string }
It is not possible for the value to be both a string and an object!
This fix allows the
value
anddefaultValue
to be set as aDateInputValue
only by usingOmit
to exclude the default types from theHTMLInputElement
type, in the same way thatlabel
was omitted.This change allows the DateInput component to work properly with
react-hook-form
which passes thevalue
into the component via theregister
function andonChange
functions.