Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mask _smtp_img_src in support string #5281

Merged
merged 1 commit into from
Dec 12, 2024
Merged

feat: mask _smtp_img_src in support string #5281

merged 1 commit into from
Dec 12, 2024

Conversation

tessus
Copy link
Contributor

@tessus tessus commented Dec 12, 2024 •
edited
Loading

The following item in the support string should be masked as well, because it reveals the domain:

"_smtp_img_src": "https://vault.example.com/vw_static/",

P.S.: domain is masked, so it's kind of strange that it then shows up in _smtp_img_src

BlackDex
BlackDex approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@BlackDex BlackDex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BlackDex BlackDex merged commit fd51230 into dani-garcia:main Dec 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamdes williamdes williamdes approved these changes

@BlackDex BlackDex BlackDex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tessus @BlackDex @williamdes