-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use a custom 404 page #2948
use a custom 404 page #2948
Conversation
It could be me, but i find the image a bit to much. And, not sure about the color, it's very much in your face hehe. |
9790193
to
4a7d350
Compare
Hm. I don't really know what color would be better. So I've removed the color for now: Not sure I'm really happy with the design either it was just a quick draft so I had something to replace the original 404.png 😞 |
4a7d350
to
4e804cd
Compare
Maybe a simple 404 would suffice? |
That looks better indeed. Besides that, it looks nice. |
4e804cd
to
bca6e85
Compare
I think that looks nice yea. |
Ow, one other item. |
bca6e85
to
c191b94
Compare
I think it looks more pofessional when the text is not centered (except the png). I like the first one much better : #2948 (comment) |
Well, only the image centered looks strange too. Also the whole Bitwarden web vault is centred by default, at least to the viewport. |
There's no accounting for taste. Just wanted to chime in, since the all centered approach looked weird to me. But I usually do not have to see that page anyway. ;-) |
Out of curiosity. Why is a png file used and not svg text? Or normal text? |
To be fair, I think Bitwarden's 404 page looks way better |
We are not holding you back to create a nice graphic 😉 . |
Initially because I wanted to simply replace the original. The original image also is linked to the web vault so you can go back easily. I think it would probably be fine to use SVG instead of PNG, I just have not considered it. |
nah, don't worry about it. The png is very small. I just didn't understand it, because the rest is just HTML text. Thus the But it doesn't really matter. This is not a page that is called thousands of times per second, so I don't care if it 2.1k instead of 100-200 bytes. |
to customize the 404 page you can copy the handlebar template `src/static/templates/404.hbs` to the TEMPLATES_FOLDER (defaults to `data/templates/`)
c191b94
to
d209df9
Compare
@BlackDex so first, I am bad at GFX, sorry haha, |
As suggested here dani-garcia/bw_web_builds#100 we might want to use a custom 404 page.
first-draft