allow registration without invite link #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
757037d to
1e7f2d5
Compare
stefan0xC
commented
Oct 6, 2022
| @@ -121,12 +117,12 @@ async fn register(data: JsonUpcase<RegisterData>, conn: DbConn) -> EmptyResult { | |||
| user_org.save(&conn).await?; | |||
| } | |||
| user | |||
| } else if EmergencyAccess::find_invited_by_grantee_email(&email, &conn).await.is_some() { | |||
| } else if CONFIG.is_signup_allowed(&email) | |||
| || EmergencyAccess::find_invited_by_grantee_email(&email, &conn).await.is_some() | |||
There was a problem hiding this comment.
The check for EmergencyAccess might be redundant in practice. I've enabled it because this way it matches the behavior of organization invites. E.g. if you allow invites, invite someone and then disable invites and disallow signup, invited users can still complete their registration. same for emergency access invites. - If we only want that for invites we should drop it to make the logic easier.
BlackDex
approved these changes
Oct 9, 2022
jjlin
suggested changes
Oct 9, 2022
ee66af9 to
75de2d7
Compare
This was referenced Oct 9, 2022
if signups are allowed invited users should be able to complete their registration even when they don't have the invite link at hand.
75de2d7 to
aa5a059
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if signups are allowed invited users should be able to complete their registration even when they don't have the invite link at hand.
fixes #2800