Fix uploads from mobile clients (and dep updates) #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the file upload send by the mobile clients. It resolves dani-garcia#2644 by always providing a `Content-Type` even though one isn't set in this specific case. I do hope it will be fixed upstream by either Bitwarden by fixing the client. Or Rocket by allowing to override this somehow. Until then, we can use this patched version of multer-rs. Issue @ Rocket: rwf2/Rocket#2299 Issue @ Bitwarden: bitwarden/mobile#2018 Also updated some dependencies.
|
@BlackDex I have opened a PR here; bitwarden/mobile#2031. |
|
@manofthepeace thx for fixing and mentioning it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the file upload send by the mobile clients.
It fixes #2644 by always providing a
Content-Typeeven though oneisn't set in this specific case.
I do hope it will be fixed upstream by either Bitwarden by fixing the
client. Or Rocket by allowing to override this somehow.
Until then, we can use this patched version of multer-rs.
Issue @ Rocket: rwf2/Rocket#2299
Issue @ Bitwarden: bitwarden/mobile#2018
Also updated some dependencies.