Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IP address to missing/invalid password message for Sends #2313

Merged

Conversation

jaen
Copy link
Contributor

@jaen jaen commented Feb 15, 2022

What it says on the tin, the messages will now include the IP of the request originator:

2022-02-13 13:29:17 | [2022-02-13 13:29:17.923][vaultwarden::api::core::sends][ERROR] Invalid password. IP: 192.168.1.246.
2022-02-13 13:29:05 | [2022-02-13 13:29:05.839][vaultwarden::api::core::sends][ERROR] Password not provided. IP: 192.168.1.246.

I have implemented this because I wanted fail2ban to also guard against trying to bruteforce Send password.

@dani-garcia dani-garcia merged commit 99f9e72 into dani-garcia:main Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants