Update Rocket to 0.5 and async, and compile on stable #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls, that are currently blocking
This is a rather large PR which updates the async branch to have all the database methods as an async fn. Some iter/map logic needed to be changed to a stream::iter().then(), but besides that most changes were just adding async/await where needed.
- Updated crates - Fixed Dockerfiles to build using the rust stable version - Enabled warnings for rust 2018 idioms and fixed them.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on top of the latest changes in main.
Seeing as there is no release of a final Rocket 0.5 in the near future, I think it's time to consider merging this as it's a big patch and hard to keep in sync.
There shouldn't be any major breaking changes, but Rocket 0.5 brings a new configuration system so that might break things for users depending on them. That said, the ones in use by most people (ROCKET_ADDRESS, ROCKET_PORT and ROCKET_TLS) are the same as before. ROCKET_ENV has changed to ROCKET_PROFILE, so anyone using that must update their config.
The file uploads are now also handled by rocket directly, and uploaded to a configurable temp directory first, before being moved to the attachments or sends folder. We should document that the temp directory and the attachments and sends folder must be in the same partition/mount point, otherwise the file move will fail.
Also I just noticed that I'm hardcoding the listen address to 0.0.0.0, I will change that before pushing.
Pending changes: