Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic ratelimit for user login (including 2FA) and admin login #2165

Merged
merged 2 commits into from
Dec 27, 2021

Conversation

dani-garcia
Copy link
Owner

Might need to adjust the default rate limiting values and explain their use better.

Also needs to document their use in the .env template.

@BlackDex
Copy link
Collaborator

That looks very simple indeed. Will be a nice addition. Ill see if i can do some checks tomorrow :).

Copy link
Collaborator

@BlackDex BlackDex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine, but i'm missing the new config values in the .env.template file :).

src/config.rs Outdated Show resolved Hide resolved
@dani-garcia dani-garcia merged commit 85ac978 into main Dec 27, 2021
@BlackDex BlackDex mentioned this pull request Dec 28, 2021
61 tasks
@dani-garcia dani-garcia deleted the ratelimit branch June 4, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants