Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin page diagnostics can't show Server Installed version #5381

Closed
jwcloverain opened this issue Jan 11, 2025 · 4 comments · Fixed by #5382
Closed

Admin page diagnostics can't show Server Installed version #5381

jwcloverain opened this issue Jan 11, 2025 · 4 comments · Fixed by #5382
Labels
bug Something isn't working

Comments

@jwcloverain
Copy link

jwcloverain commented Jan 11, 2025 •
edited
Loading

Vaultwarden Support String

click Generate Support String button not working

Vaultwarden Build Version

1.32.7-4f68eafa-linux-armv7-alpine

Deployment method

Downloaded from GitHub Actions Release Workflow

Custom deployment method

No response

Reverse Proxy

caddy 2.9.1

Host/Server Operating System

Linux

Operating System Version

No response

Clients

Web Vault

Client Version

No response

Steps To Reproduce

Click admin page diagnostics

Expected Result

admin page diagnostics show Server Installed version

Actual Result

update to 1.32.7-4f68eafa-linux-armv7-alpine, admin pagel can't show Server Installed version,
151712
browser console shows the following error
151628
maybe #5378 break this

Logs

No response

Screenshots or Videos

No response

Additional Context

No response
@jwcloverain jwcloverain added the bug Something isn't working label Jan 11, 2025
@BlackDex
Copy link
Collaborator

Thanks for reporting. I can verify this to.
My guess is probably the updated bake action.
The attest doesn't modify the files.

@jwcloverain jwcloverain changed the title Admin pagel diagnostics can't show Server Installed version Admin page diagnostics can't show Server Installed version Jan 11, 2025
@stefan0xC
Copy link
Contributor

stefan0xC commented Jan 11, 2025 •
edited
Loading

My guess is probably the updated bake action.

Yeah, sounds plausible.

Maybe we could use SOURCE_VERSION instead of relying on the full git history being present?

vaultwarden/.github/workflows/release.yml

Line 68 in 4f68eaf

fetch-depth: 0

@BlackDex
Copy link
Collaborator

We probably just need to add the source: . option to the bake action.

@BlackDex BlackDex mentioned this issue Jan 11, 2025
Merged
BlackDex added a commit to BlackDex/vaultwarden that referenced this issue Jan 11, 2025
@BlackDex
Fix version detection on bake
fddc03f 
Because of some changes in the bake action the version was not able to be extracted.

Fixes dani-garcia#5381

Signed-off-by: BlackDex <black.dex@gmail.com>
@BlackDex
Copy link
Collaborator

Just double-checked it on my phone, and i do see a version now.

Thanks again for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix version detection on bake BlackDex/vaultwarden
3 participants
@stefan0xC @BlackDex @jwcloverain