-
-
Notifications
You must be signed in to change notification settings - Fork 2k
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push Updates NOT working on iOS, but work perfectly for Droid and Web #5002
Comments
btw. Let me know if there's any effort underway to create a VaultWarden-specific IOS/droid app. I'd be inclined to help. |
And in case it's asked, I did answer both popups to allow push notifications, on the iOS device, each time I installed the app to test notifications. |
There are several Bitwarden compatibel apps already. I do not think this project has the time to also take an effort on that part. |
@LeeWhite187 don't dox yourself, I'm hoping you replaced that IP with a fake one. |
As this is not a Vaultwarden specific issue, but more a Bitwarden issue with the new clients I'm going to move this to discussions. |
It seems the iOS clients are not able to handle the `type` key within the `fields` array when they are of the type string. All other clients seem to handle this just fine though. This PR fixes this by validating it is a number, if this is not the case, try to convert the string to a number, or return the default of `1`. `1` is used as this is the type `hidden` and should prevent accidental data disclosure. Fixes dani-garcia#5069 Possibly Fixes dani-garcia#5016 Possibly Fixes dani-garcia#5002 Signed-off-by: BlackDex <black.dex@gmail.com>
It seems the iOS clients are not able to handle the `type` key within the `fields` array when they are of the type string. All other clients seem to handle this just fine though. This PR fixes this by validating it is a number, if this is not the case, try to convert the string to a number, or return the default of `1`. `1` is used as this is the type `hidden` and should prevent accidental data disclosure. Fixes #5069 Possibly Fixes #5016 Possibly Fixes #5002 Signed-off-by: BlackDex <black.dex@gmail.com>
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Vaultwarden Support String
Your environment (Generated via diagnostics page)
Config (Generated via diagnostics page)
Show Running Config
Environment settings which are overridden: DOMAIN, ADMIN_TOKEN
Vaultwarden Build Version
1.32.0
Deployment method
Official Container Image
Custom deployment method
self-hosted vaultwarden
Running behind an nginx proxy, following the several examples in the guide, with websocket (web ui sync) working well for connected clients.
Reverse Proxy
nginx/1.18.0 (Ubuntu)
Host/Server Operating System
Linux
Operating System Version
Ubuntu 20.04.6 LTS (GNU/Linux 5.15.0-72-generic x86_64)
Clients
iOS
Client Version
Bitwarden app version: 2024.9.2, on iOS 16.1.1
Steps To Reproduce
Expected Result
Adding a new item to a user's vault from the web ui, triggers a push notification for a droid client.
Adding a new item to a user's vault from the web ui, triggers a push notification for an iOS client.
Actual Result
Adding a new item to a user's vault from the web ui, triggers a push notification for a droid client.
Adding a new item to a user's vault from the web ui, DOES NOT trigger a push notification for an iOS client.
Logs
Screenshots or Videos
No response
Additional Context
Automatic sync works well between web ui clients, indicating the websocket connection works for connected clients.
Automatic sync works well for the droid app, indicating that push notifications are successfully conveyed to bitwarden's push brokering service.
However, no push notifications are received (or acted on) by the Bitwarden iOS app instance.
Immediately following a failed push (iOS app not updating with changes made to user vault from android or web), I was able to successfully exchange text iMessages between the iOS device under test and another iphone, indicating that the iOS device under test has a viable client websocket connection to the APNS gateway.
As well. I'm seeing the same failing Bitwarden push update for the iOS device under test, while on both Wifi and cell service networks. While the manual sync (of the iOS app) works as expected from both networks.
Also. I have renewed the installation id and key (needed for push), deleted the user, and deleted and reinstalled the Bitwarden iOS app... several times now, while reading through every closed and open GH issue about push and iOS problems.
I've even torn down everything, and stood up each piece (container, client, and user) from new.
As well. tried the deauth/delete/recreate method that I found in a similar issue. But, that does NOT resolve the iOS push problem, either.
After reading all the open and closed issues about push notification problems on iOS, and trying what each has, I still cannot get iOS push notifications to work.
But, Android push and web-ui sync (via websocket) both work fine through each iteration.
Any ideas?
Thanks,
Lee
The text was updated successfully, but these errors were encountered: