Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update web-vault to v2024.3.1 #159

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

stefan0xC
Copy link
Contributor

New web-vault version: web-v2024.3.1

I've not checked if we need to change anything else server-side. (Basic stuff still works, also running Vaultwarden in a alternate base dir, but have not tested everything, e.g. duo connector...)

@BlackDex
Copy link
Collaborator

BlackDex commented Apr 4, 2024

Looks like there are some changes in the event collections, but not sure that has an impact.

There now is a bulk collection update option.
bitwarden/clients@bac0874

That is probably something we might need to update our add something for on the server side.

@BlackDex
Copy link
Collaborator

BlackDex commented Apr 5, 2024

I just noticed that there is a call done for every org during login.
https://127.0.0.1/api/organizations/<org_uuid>/billing-status, can we prevent this maybe?

@stefan0xC
Copy link
Contributor Author

stefan0xC commented Apr 5, 2024

I just noticed that there is a call done for every org during login. https://127.0.0.1/api/organizations/<org_uuid>/billing-status, can we prevent this maybe?

Did you check with v2024.3.0 because I thought I've already patched this behavior out for this version.
Compare stefan0xC/bitwarden_clients@c4de547 vs stefan0xC/bitwarden_clients@d6b1c81

@stefan0xC
Copy link
Contributor Author

Ah yes, just checked and it happens with v2024.3.0. I can backport the changes to the v2024.3.0.patch.

@BlackDex
Copy link
Collaborator

BlackDex commented Apr 5, 2024

Nea, i think this release can be the final one and added to Vaultwarden instead of the 2024.3.0.

@BlackDex
Copy link
Collaborator

BlackDex commented Apr 6, 2024

Since the new bulk collection feature is behind a feature-flag, lets merge this :).

@BlackDex BlackDex merged commit 9d64c88 into dani-garcia:master Apr 6, 2024
@stefan0xC stefan0xC deleted the update-to-v2024.3.1 branch April 6, 2024 09:28
@tessus
Copy link
Contributor

tessus commented Apr 7, 2024

The more important question is whether a new API endpoint is required for the feature flag to work.

@BlackDex
Copy link
Collaborator

BlackDex commented Apr 7, 2024

The more important question is whether a new API endpoint is required for the feature flag to work.

Probably yes, or at least changes to existing ones, since else a feature flag would not be needed.

@Gerardv514
Copy link

In dark mode, under preferences screen you can’t see the field drop down indicators on each field, but they are viewable on light theme.

@stefan0xC
Copy link
Contributor Author

@Gerardv514 I don't think I have that problem (at least in Firefox):
Screenshot 2024-04-08 at 07-28-29 Preferences Vaultwarden Web
Screenshot 2024-04-08 at 07-30-14 Preferences Vaultwarden Web

Did you fully reload the page? I mean if you can recreate this with Bitwarden Cloud (https://vault.bitwarden.com/), I would suggest you create an issue in https://github.com/bitwarden/clients/issues with more details (i.e. OS/Browser version, etc) since this should probably be addressed upstream then.

@Gerardv514
Copy link

👍 @stefan0xC Seems like this behavior only occurs on mobile browsers (tested on iPhone, Chrome & Safari browsers). Issue does not exist on computer browser. Minor issue, and probably exists upstream.

@BlackDex
Copy link
Collaborator

👍 @stefan0xC Seems like this behavior only occurs on mobile browsers (tested on iPhone, Chrome & Safari browsers). Issue does not exist on computer browser. Minor issue, and probably exists upstream.

I'm not having issues on my mobile either.

@Gerardv514
Copy link

Gerardv514 commented Apr 10, 2024

Hmm odd..

IMG_3417
IMG_3416

@BlackDex
Copy link
Collaborator

Screenshot_20240410-182611~2

@Gerardv514
Copy link

Gerardv514 commented Apr 14, 2024

@BlackDex what browser and device is your screenshot above from? I noticed that this is probably a desktop browser. Desktop browsers only show the down arrow, as is also shown in @stefan0xC screenshot above where he mentioned firefox (probably desktop too??), whereas the mobile browsers show an up and down arrow.

  • The issue exists upstream as well. I create a BW account, and can confirm on mobile browsers this is a problem.

@Gerardv514
Copy link

Gerardv514 commented Apr 14, 2024

@stefan0xC question, when in Light Theme for VW, why is the password manager side bar black (as if in dark theme) rather than the default blue in BW?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants