Update for Angular 8 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't have time to figure out how to test this with the ng add *** utility, so hopefully it works. I was able to test my version of ng-add-pug-loader.js (after filling in the templated parts)
danguilherme
requested changes
Jun 12, 2019
There was a problem hiding this comment.
Thank you so much for this PR! This will probably solve #19 too.
As Angular 6 is still in LTS, I believe we should keep supporting it, thus some small changes must be made.
|
Hi, Thanks for the feedback. I'm working on it, but it's taking longer than expected due to running into a weird issue where adding the typescript.js file to the UnitTestTree is causing the other unit tests dependent on common.js to fail as undefined. If I simply rename the new file, everything continues to work. So that's weird, has something to do with the name I guess.
|
Add a unit test for Angular 8 Add a check to maintain Angular 6/7 compatability per PR feedback
danguilherme
requested changes
Jun 13, 2019
…ript make changes requested in PR: * fix typo on unit test description * refactor variable names relating to version of Angular * alter mocked unit test file utilize subset of typescript.js
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified my local script ng-ad-pug-loader.js script and tried to make the changes to this library. I didn't have time to figure out how to test if what I've done works with ng add , but I think I haven't made any mistakes. If you want to merge this in, go ahead. The main thing to do is set directTemplateLoading to false in the webpack cli config typecript.js file.
Fixes #20
ng-add-pug-loader.js.zip