Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Swift 5.2 #419

Merged
merged 2 commits into from
Mar 20, 2021
Merged

Switch to Swift 5.2 #419

merged 2 commits into from
Mar 20, 2021

Conversation

lunij
Copy link
Contributor

@lunij lunij commented Feb 28, 2021

Please see #414 for more information

@lunij
Copy link
Contributor Author

lunij commented Feb 28, 2021

@orta @f-meloni How do you decide about the minimum Swift version? Should it be supported by swiftenv? In case of 5.2 it would be 5.2.4.

@f-meloni
Copy link
Member

5.2.4 looks good to me as swiftenv version, as long as SPM declares 5.2 it should be fine

@lunij
Reference dependency names explicitly
0033291 
This is required by SwiftPM 5.2
@lunij lunij mentioned this pull request Feb 28, 2021
Closed
@lunij lunij marked this pull request as ready for review February 28, 2021 19:32
f-meloni
f-meloni approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@f-meloni f-meloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I will make a release before merging that will be the latest with swift 5.1 support

@f-meloni f-meloni merged commit ad1f4be into danger:master Mar 20, 2021
@lunij lunij deleted the marc/swift-5.2 branch April 18, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-meloni f-meloni f-meloni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lunij @f-meloni