Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tslint to the latest version 🚀 #203

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"shx": "^0.2.1",
"ts-jest": "^19.0.0",
"ts-node": "^3.0.0",
"tslint": "^4.4.0",
"tslint": "^5.0.0",
"typescript": "2.2.1"
},
"dependencies": {
Expand Down
28 changes: 14 additions & 14 deletions source/ambient.d.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
declare module "parse-diff";
declare module "lodash.includes";
declare module "lodash.find";
declare module "lodash.isarray";
declare module "lodash.isobject";
declare module "lodash.keys";
declare module "jest-runtime";
declare module "jest-environment-node";
declare module "jest-config";
declare module "voca";
declare module "jsome";
declare module "jsonpointer";
declare module "parse-diff"
declare module "lodash.includes"
declare module "lodash.find"
declare module "lodash.isarray"
declare module "lodash.isobject"
declare module "lodash.keys"
declare module "jest-runtime"
declare module "jest-environment-node"
declare module "jest-config"
declare module "voca"
declare module "jsome"
declare module "jsonpointer"

// This must exist...
declare module "chalk";
declare module "chalk"

declare module "*/package.json";
declare module "*/package.json"
2 changes: 1 addition & 1 deletion source/ci_source/providers/Circle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class Circle implements CISource {
const reponame = splitSlug[4]
const id = splitSlug[6]
return {owner, reponame, id}
};
}
return {}
}

Expand Down
2 changes: 1 addition & 1 deletion source/ci_source/providers/DockerCloud.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class DockerCloud implements CISource {
const reponame = splitSlug[4]
const id = splitSlug[6]
return {owner, reponame, id}
};
}
return {}
}

Expand Down
2 changes: 1 addition & 1 deletion source/ci_source/providers/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ const realProviders = [Travis, Circle, Semaphore, Jenkins, Surf, DockerCloud, Co
export {
providers,
realProviders
};
}
1 change: 0 additions & 1 deletion tslint.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
"no-var-keyword": true,
"no-empty": true,
"no-unused-expression": true,
"no-use-before-declare": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a breaking change in TSLint 5.0. See the release notes or palantir/tslint#2235 for more details. We good to remove this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, when I made a ts-lint linter I used that, this seems 👍 to me

"no-var-requires": true,
"no-require-imports": true,
"one-line": [true,
Expand Down
Loading