Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly include "data packages" in project #138

Merged
merged 1 commit into from
Sep 10, 2022
Merged

Properly include "data packages" in project #138

merged 1 commit into from
Sep 10, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jun 9, 2022

There is a folder in dandischema/ that contains data files but no Python source code, and we want this folder to be included when dandischema is installed. Currently, this folder is automatically included by the combination of graft dandischema in MANIFEST.in and include_package_data = True in setup.cfg, but because we set packages in setup.cfg to find: instead of find_namespace:, the folder itself is not recognized by setuptools as a package. This combination of settings is deprecated, and the setuptools developers recommend using find_namespace: instead of find: for such situations.

@jwodder jwodder added the internal Changes only affect the internal API label Jun 9, 2022
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #138 (059b642) into master (148a18c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   96.67%   96.67%           
=======================================
  Files          18       18           
  Lines        1654     1654           
=======================================
  Hits         1599     1599           
  Misses         55       55           
Flag Coverage Δ
unittests 96.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 148a18c...059b642. Read the comment docs.

@satra satra added minor Increment the minor version when merged patch Increment the patch version when merged and removed minor Increment the minor version when merged labels Sep 10, 2022
@satra satra merged commit c3d9a61 into master Sep 10, 2022
@satra satra deleted the data-pkg branch September 10, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants