Fix/schemakey metaclass #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## fix/schemakey #13 +/- ##
=================================================
- Coverage 94.34% 94.02% -0.33%
=================================================
Files 11 11
Lines 814 787 -27
=================================================
- Hits 768 740 -28
- Misses 46 47 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
we have it but was not forced upon me ;-) |
…hemaKey Overloading is allowed by simply specifying the name to be used while declaring the class in the source code.
Somehow I do not run into this behavior with pydantic 1.8.2 when using custom metaclass. Might be a sign of trouble but all tests pass, so I decided just to condition on having "enum". But then saw that resultant schema lacks "const" so reworked to add "const" even if not enum. May be that is not desired?
b807fa6 to
3f557ea
Compare
|
we are abusing schemaKey a bit. while we are making a distinction in the code between publishedasset and publisheddandiset, they are both of type dandiset and asset. i.e. the publishing metadata does not change the type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commit messages for some extra metadata.
Supplement to #6
May be we should drop that
enumspecial handling altogether and then assignment of thatconst?edit: FWIW tried to sort
dctin metaclass for no effect on produced jsonschema