-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ember instance types for DANDI CLI #1565
Conversation
By adding an ember instance type (and ember-staging), the DANDI CLI should be able to be used as-is rather than requiring a custom PyPI. dandi#1517 dandi#1527
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1565 +/- ##
==========================================
+ Coverage 88.36% 88.42% +0.05%
==========================================
Files 78 78
Lines 10735 10735
==========================================
+ Hits 9486 9492 +6
+ Misses 1249 1243 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for getting these started!!
Just added a few changes to the URLs as we've modified them since first starting on this effort. Thanks!
THANKS @NEStock ! Note that in DANDI itself we are moving away from |
@yarikoptic Thanks for the note! I agree, I think it makes sense to EMBER to switch to sandbox as well for consistency! We can look into making that change in our forks of dandi-archive and dandi-infrastructure! |
Apply suggestions from code review Co-authored-by: Nicole Stock <nicoleelizabeth888@gmail.com>
@yarikoptic CC @asmacdo @laurendiaz @sandyhider |
it's just a name, it can easily be the one you choose, there is no "semantic" really attached to it (I hope) anywhere. So you could keep it 'staging' if that is what you have ATM, and then spend time migrating. I guess during 'merges' you would run into conflicts for corresponding lines anyway in infrastructure etc, so just need to be careful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using staging
for now! thanks!
Co-authored-by: Nicole Stock <nicoleelizabeth888@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
🚀 PR was released in |
This should not merge until these endpoints actually exist, but may be helpful to the Ember team to have this as a draft anyway.
By adding an ember instance type (and ember-staging), the DANDI CLI should be able to be used as-is rather than requiring a custom PyPI.
#1517
#1527