Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ember instance types for DANDI CLI #1565

Merged
merged 6 commits into from
Feb 12, 2025
Merged

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Jan 15, 2025

This should not merge until these endpoints actually exist, but may be helpful to the Ember team to have this as a draft anyway.

By adding an ember instance type (and ember-staging), the DANDI CLI should be able to be used as-is rather than requiring a custom PyPI.

#1517
#1527

By adding an ember instance type (and ember-staging), the DANDI CLI
should be able to be used as-is rather than requiring a custom PyPI.

dandi#1517
dandi#1527
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.42%. Comparing base (ba384c6) to head (d814f95).
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1565      +/-   ##
==========================================
+ Coverage   88.36%   88.42%   +0.05%     
==========================================
  Files          78       78              
  Lines       10735    10735              
==========================================
+ Hits         9486     9492       +6     
+ Misses       1249     1243       -6     
Flag Coverage Δ
unittests 88.42% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaronkanzer
Copy link
Member

Cc @NEStock @laurendiaz

Copy link
Contributor

@NEStock NEStock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for getting these started!!

Just added a few changes to the URLs as we've modified them since first starting on this effort. Thanks!

@yarikoptic
Copy link
Member

THANKS @NEStock ! Note that in DANDI itself we are moving away from staging ATM into sandbox. May be the same should be done for ember "earlier the better"? References for motivation etc

@NEStock
Copy link
Contributor

NEStock commented Feb 6, 2025

THANKS @NEStock ! Note that in DANDI itself we are moving away from staging ATM into sandbox. May be the same should be done for ember "earlier the better"? References for motivation etc

@yarikoptic Thanks for the note! I agree, I think it makes sense to EMBER to switch to sandbox as well for consistency! We can look into making that change in our forks of dandi-archive and dandi-infrastructure!

asmacdo and others added 2 commits February 6, 2025 12:20
Apply suggestions from code review

Co-authored-by: Nicole Stock <nicoleelizabeth888@gmail.com>
@NEStock
Copy link
Contributor

NEStock commented Feb 11, 2025

THANKS @NEStock ! Note that in DANDI itself we are moving away from staging ATM into sandbox. May be the same should be done for ember "earlier the better"? References for motivation etc

@yarikoptic Thanks for the note! I agree, I think it makes sense to EMBER to switch to sandbox as well for consistency! We can look into making that change in our forks of dandi-archive and dandi-infrastructure!

@yarikoptic CC @asmacdo @laurendiaz @sandyhider
Would it be okay if we stick with staging for now and then make a plan to move over to sandbox soon?
We're on a very tight timeline for getting EMBER-DANDI stood up, so removing any non-essential blockers would greatly help our team! Thanks!

@yarikoptic
Copy link
Member

@yarikoptic CC @asmacdo @laurendiaz @sandyhider
Would it be okay if we stick with staging for now and then make a plan to move over to sandbox soon?

it's just a name, it can easily be the one you choose, there is no "semantic" really attached to it (I hope) anywhere. So you could keep it 'staging' if that is what you have ATM, and then spend time migrating. I guess during 'merges' you would run into conflicts for corresponding lines anyway in infrastructure etc, so just need to be careful.

Copy link
Contributor

@NEStock NEStock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using staging for now! thanks!

Co-authored-by: Nicole Stock <nicoleelizabeth888@gmail.com>
Copy link
Contributor

@NEStock NEStock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@asmacdo asmacdo marked this pull request as ready for review February 12, 2025 16:20
@asmacdo asmacdo merged commit 746650f into dandi:master Feb 12, 2025
24 checks passed
Copy link

🚀 PR was released in 0.66.6 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants