-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue 3 feature branch #2186
Draft
mvandenburgh
wants to merge
92
commits into
master
Choose a base branch
from
vue3-feature-branch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Vue 3 feature branch #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9209224
to
e0a2126
Compare
Options used: ✔ Project name: … dandi-archive ✔ Which preset would you like to install? › Default (Adds routing, ESLint & SASS variables) ✔ Use TypeScript? … Yes ✔ Would you like to install dependencies with yarn, npm, pnpm, or bun? › yarn
[plugin:vite:vue] <template v-for> key should be placed on the <template> tag.
Uncaught SyntaxError: The requested module '/node_modules/.vite/deps/filesize.js?v=b525104e' does not provide an export named 'default'
The `vue-social-sharing` package is not compatible with Vue 3. We will need to find an alternative package or implement the functionality ourselves.
This requires a rewrite to work with Vue 3, so it will be done in a separate PR.
e0a2126
to
de1a897
Compare
The Vue 3 app now requires Node 20.
de1a897
to
a0c9dae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.