-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rand_core to 0.6 #64
Update rand_core to 0.6 #64
Conversation
https://github.com/rust-random/rand/blob/master/rand_core/CHANGELOG.md This new version makes using rand_core on wasm seamless (thanks to the update of getrandom to v0.2) The crate compiles well with this PR, but since some rand_core traits are publicly exposed in this crate's API, this is strictly speaking a breaking change.
it'll be very useful for a crate like https://github.com/novifinancial/opaque-ke to be used in a browser |
Sorry if I overlooked something, but is Line 229 in 0985e1b
getrandom and removed this line, then tried e.g. cargo test --features=default,serde,std,u64_backend and it seemed ok.
|
Which allows to not use the "getrandom" feature of the rand_core create. Thanks to Frederick Zhang (@Frederick888) for the suggestion: dalek-cryptography#64 (comment)
@Frederick888 I pushed a new commit removing the use of |
Any status updates on this PR? |
It seems that there is an issue with the leadership and release process at |
Hey, I'm happy to merge this into a 2.x alpha which tracks the curve25519-dalek 4.x alphas, if that is a tenable solution to fix problems in production deploys which want the latest rand. I don't have a hard date set yet for releasing those new major versions, as I would like to minimise future backporting efforts, but also maximise downstream compatibility and batch enough breaking changes together to not be a continual breakage point. Thoughts, anyone? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PaulGrandperrin!
https://github.com/rust-random/rand/blob/master/rand_core/CHANGELOG.md
This new version makes using rand_core on wasm seamless (thanks to the update of getrandom to v0.2)
The crate compiles well with this PR, but since some rand_core traits are publicly exposed in this crate's API, this is strictly speaking a breaking change.