Issue SeasideSt#59: add error stack logging to try to characterize ra…

…ndom test error
dalehenrich · Dec 15, 2014 · e298fe8 · e298fe8
1 parent 39d7234
commit e298fe8
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/...emServer-Tests.package/SeasideGemServerTests.class/instance/testStartRestartStopServer.st b/...emServer-Tests.package/SeasideGemServerTests.class/instance/testStartRestartStopServer.st
@@ -2,6 +2,7 @@ tests
 testStartRestartStopServer
   "just start/restart/stop ... without an http client cannot do much else"
 
+  [ 
   | gemServer |
   gemServer := self gemServer.
   [ 
@@ -21,4 +22,12 @@ testStartRestartStopServer
     ensure: [ 
       gemServer stopGems.
       (Delay forSeconds: 3) wait.
-      self validatePidFile: gemServer shouldExist: false ]
+      self validatePidFile: gemServer shouldExist: false ] ]
+    on: Error
+    do: [ :ex | 
+      Transcript
+        cr;
+        show: 'testStartRestartStopServer (Issue #59)';
+        cr;
+        show: (GsProcess stackReportToLevel: 100).
+      ex pass ]
diff --git a/...easide-GemStone-GemServer-Tests.package/SeasideGemServerTests.class/methodProperties.json b/...easide-GemStone-GemServer-Tests.package/SeasideGemServerTests.class/methodProperties.json
@@ -9,7 +9,7 @@
 		"setUp" : "dkh 12/10/2014 16:24",
 		"tearDown" : "dkh 12/10/2014 16:24",
 		"testSimpleGet" : "dkh 12/10/2014 20:09",
-		"testStartRestartStopServer" : "dkh 12/14/2014 15:27",
+		"testStartRestartStopServer" : "dkh 12/15/2014 15:24",
 		"testWAGemStoneProductionErrorHandler" : "dkh 12/10/2014 21:08",
 		"testWAGemStoneWalkbackErrorHandler" : "dkh 12/11/2014 13:59",
 		"testWARemoteDebuggingWalkbackErrorHandler" : "dkh 12/10/2014 21:09",

diff --git a/repository/Seaside-GemStone-GemServer-Tests.package/monticello.meta/version b/repository/Seaside-GemStone-GemServer-Tests.package/monticello.meta/version
@@ -1 +1 @@
-(name 'Seaside-GemStone-GemServer-Tests-dkh.3' message 'Issue #54: implement statusGems so that maintenance vm status is included for seaside gem servers ... add statusGem to tests' id '25fc060c-b6c7-47c5-92ac-50577a22ec91' date '12/14/2014' time '15:35:11' author 'dkh' ancestors ((name 'Seaside-GemStone-GemServer-Tests-dkh.2' message 'Issue #54: fiddle with dependencies surrounding Seaside-GemStone-GemServer-Tests' id '52bbcbe3-2ae8-4742-b26c-23ac178f7e66' date '12/14/2014' time '12:51:46' author 'dkh' ancestors ((name 'Seaside-GemStone-GemServer-Tests-dkh.1' message 'Issue #54: split Seaside-GemStone-GemServer into two packages: Seaside-GemStone-GemServer-Core and Seaside-GemStone-GemServer-Tests' id 'c4940b3a-0278-4eab-9360-5004ab1ac593' date '12/14/2014' time '12:06:45' author 'dkh' ancestors () stepChildren ())) stepChildren ())) stepChildren ())
+(name 'Seaside-GemStone-GemServer-Tests-dkh.4' message 'Issue #59: add error stack logging to try to characterize random test error' id 'c980937b-85bc-4bbc-821c-0bacd041830d' date '12/15/2014' time '15:25:04' author 'dkh' ancestors ((name 'Seaside-GemStone-GemServer-Tests-dkh.3' message 'Issue #54: implement statusGems so that maintenance vm status is included for seaside gem servers ... add statusGem to tests' id '25fc060c-b6c7-47c5-92ac-50577a22ec91' date '12/14/2014' time '15:35:11' author 'dkh' ancestors ((name 'Seaside-GemStone-GemServer-Tests-dkh.2' message 'Issue #54: fiddle with dependencies surrounding Seaside-GemStone-GemServer-Tests' id '52bbcbe3-2ae8-4742-b26c-23ac178f7e66' date '12/14/2014' time '12:51:46' author 'dkh' ancestors ((name 'Seaside-GemStone-GemServer-Tests-dkh.1' message 'Issue #54: split Seaside-GemStone-GemServer into two packages: Seaside-GemStone-GemServer-Core and Seaside-GemStone-GemServer-Tests' id 'c4940b3a-0278-4eab-9360-5004ab1ac593' date '12/14/2014' time '12:06:45' author 'dkh' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		(name 'Seaside-GemStone-GemServer-Tests-dkh.3' message 'Issue #54: implement statusGems so that maintenance vm status is included for seaside gem servers ... add statusGem to tests' id '25fc060c-b6c7-47c5-92ac-50577a22ec91' date '12/14/2014' time '15:35:11' author 'dkh' ancestors ((name 'Seaside-GemStone-GemServer-Tests-dkh.2' message 'Issue #54: fiddle with dependencies surrounding Seaside-GemStone-GemServer-Tests' id '52bbcbe3-2ae8-4742-b26c-23ac178f7e66' date '12/14/2014' time '12:51:46' author 'dkh' ancestors ((name 'Seaside-GemStone-GemServer-Tests-dkh.1' message 'Issue #54: split Seaside-GemStone-GemServer into two packages: Seaside-GemStone-GemServer-Core and Seaside-GemStone-GemServer-Tests' id 'c4940b3a-0278-4eab-9360-5004ab1ac593' date '12/14/2014' time '12:06:45' author 'dkh' ancestors () stepChildren ())) stepChildren ())) stepChildren ())
		(name 'Seaside-GemStone-GemServer-Tests-dkh.4' message 'Issue #59: add error stack logging to try to characterize random test error' id 'c980937b-85bc-4bbc-821c-0bacd041830d' date '12/15/2014' time '15:25:04' author 'dkh' ancestors ((name 'Seaside-GemStone-GemServer-Tests-dkh.3' message 'Issue #54: implement statusGems so that maintenance vm status is included for seaside gem servers ... add statusGem to tests' id '25fc060c-b6c7-47c5-92ac-50577a22ec91' date '12/14/2014' time '15:35:11' author 'dkh' ancestors ((name 'Seaside-GemStone-GemServer-Tests-dkh.2' message 'Issue #54: fiddle with dependencies surrounding Seaside-GemStone-GemServer-Tests' id '52bbcbe3-2ae8-4742-b26c-23ac178f7e66' date '12/14/2014' time '12:51:46' author 'dkh' ancestors ((name 'Seaside-GemStone-GemServer-Tests-dkh.1' message 'Issue #54: split Seaside-GemStone-GemServer into two packages: Seaside-GemStone-GemServer-Core and Seaside-GemStone-GemServer-Tests' id 'c4940b3a-0278-4eab-9360-5004ab1ac593' date '12/14/2014' time '12:06:45' author 'dkh' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())