Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor with AST #70

Merged
merged 4 commits into from
Jul 8, 2022
Merged

Refactor with AST #70

merged 4 commits into from
Jul 8, 2022

Conversation

daixiang0
Copy link
Owner

@daixiang0 daixiang0 commented Jul 8, 2022

  • refactor parse with AST
  • simplify section logic
  • desperate rarely used flags
  • all configs are not case sensitive

Signed-off-by: Loong Dai loong.dai@intel.com

Signed-off-by: Loong Dai <loong.dai@intel.com>
daixiang0 added 3 commits July 8, 2022 18:21
Signed-off-by: Loong Dai <loong.dai@intel.com>
Signed-off-by: Loong Dai <loong.dai@intel.com>
Signed-off-by: Loong Dai <loong.dai@intel.com>
@daixiang0
Copy link
Owner Author

Fix #50

@daixiang0 daixiang0 merged commit 856d805 into master Jul 8, 2022
@daixiang0 daixiang0 deleted the v2 branch July 8, 2022 11:16
"github.com/daixiang0/gci"

g "github.com/golang"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not have changed, this looks to be a bug: the gci is running std, default, prefix(github.com/daixiang0/gci).

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config order is not the final order, please check README.

@daixiang0 daixiang0 mentioned this pull request Jul 19, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants