Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action: use latest version (unless version is specified) #269

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

MPV
Copy link
Contributor

@MPV MPV commented Oct 9, 2023

...to lower the maintenance need for this action (keeping it updated when there's newer versions of Octopilot released).

TODO:

  • Manually verify that both scenarios (with & without version) works as intended.

@vbehar
Copy link
Collaborator

vbehar commented Oct 17, 2023

@MPV thanks for your PR. Do you need anything to finish it?

action.yml Outdated Show resolved Hide resolved
action.yml Show resolved Hide resolved
action.yml Show resolved Hide resolved
@MPV MPV marked this pull request as ready for review October 18, 2023 08:55
@MPV MPV requested a review from vbehar as a code owner October 18, 2023 08:55
@MPV
Copy link
Contributor Author

MPV commented Oct 18, 2023

@vbehar This is now ready.
I have tested it over here:

It works on ubuntu-latest (i.e. not yet on macos-latest / darwin), but that can be improved in a later PR/change imho.

@MPV
Copy link
Contributor Author

MPV commented Oct 18, 2023

Rebased from master. Feel free to squash this into master (if/as you see fit).
Let me know if you need me to squash it first instead.

@MPV
Copy link
Contributor Author

MPV commented Oct 18, 2023

I haven't added any workflow testing the action, but I suppose you could do something like what I did:

...maybe with something like this to avoid it running on any PRs when not needed:

[...]
on:
  pull_request:
    paths:
    - action.yml

...as per:

...but not a must-have in this PR, so I'll leave it for later.

@vbehar
Copy link
Collaborator

vbehar commented Oct 18, 2023

thanks! Yes, ideally if you can squash & sign your commit, then I'll be able to merge it

@MPV
Copy link
Contributor Author

MPV commented Oct 18, 2023

@vbehar squashed and signed now, feel free to proceed.

@vbehar
Copy link
Collaborator

vbehar commented Oct 18, 2023

@vbehar squashed and signed now, feel free to proceed.

sorry, I meant GPG-signed, not signed-off. As explained in https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits (it's a requirement we have in this repo...)

...to lower the maintenance need for this action (keeping it updated when there's newer versions of Octopilot released).

Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>
@MPV
Copy link
Contributor Author

MPV commented Oct 18, 2023

@vbehar How about now? The commit says Verified when I look at it — hope I got it right. 😊

@vbehar vbehar enabled auto-merge (squash) October 18, 2023 09:30
@vbehar vbehar merged commit 8b00c3c into dailymotion-oss:master Oct 18, 2023
@vbehar
Copy link
Collaborator

vbehar commented Oct 18, 2023

perfect, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants