-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Action: use latest
version (unless version is specified)
#269
Conversation
@MPV thanks for your PR. Do you need anything to finish it? |
@vbehar This is now ready.
It works on |
Rebased from master. Feel free to squash this into master (if/as you see fit). |
I haven't added any workflow testing the action, but I suppose you could do something like what I did:
...maybe with something like this to avoid it running on any PRs when not needed: [...]
on:
pull_request:
paths:
- action.yml ...as per: ...but not a must-have in this PR, so I'll leave it for later. |
thanks! Yes, ideally if you can squash & sign your commit, then I'll be able to merge it |
@vbehar squashed and signed now, feel free to proceed. |
sorry, I meant GPG-signed, not signed-off. As explained in https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits (it's a requirement we have in this repo...) |
...to lower the maintenance need for this action (keeping it updated when there's newer versions of Octopilot released). Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>
@vbehar How about now? The commit says |
perfect, thanks a lot! |
...to lower the maintenance need for this action (keeping it updated when there's newer versions of Octopilot released).
TODO: